-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate bbox darrow #3194
Annotate bbox darrow #3194
Conversation
Good idea. @leejjoon - would you mind taking a look? |
|
||
return path | ||
|
||
_style_list['darrow']=DArrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fixed now.
I think I've added the spaces you were looking for. |
Is there anything I need to do to move this pull request forward? Do I need to do anything about the Travis CI error? |
I restarted the tests. The 1.5.x stuff is a bit on hold until we finish up 1.4.0, although now that we have created the 1.4.x branch we can start merging new stuff again. |
And yes, please fix the pep8 failures |
Thank you for getting back to me so quickly. I'm having trouble interpreting the Travis CI output. Does it tell me where/if I have pep8 failures? I see warnings/errors in other files, but none in files I have committed. Thank you. I've done my best to make my changes pep8 compliant. |
I think these issues were present at the time where you branched from master. You should probably rebase on current master to fix the errors if possible. |
Thanks for the help everyone! |
Could you and an image test to go with this? |
OK, I think I've added an image test, but the test is failing in the TCI build. I used the figures that were generated on my machine when I ran the test. I think I've disabled all of my matplotlib customizations. Is there something else going on here, or do I need to create a much cleaner (i.e. using virtualenv) matplotlib install and create the images with that? Do I need to change my backend? Other ideas? |
The issue isn't that the images are not matching, it's that you are getting errors during rendering
The other two are the same, just for the other backends. We probably only need the png version of this test. |
OK. Now I'm really confused. Does anyone have any ideas as to why the python2 image tests are passing, but not python3? FYI, I was getting the following warning when running tests on my local machine:
in order to create the test image I had to set Anyway, I guess I'm talking about two issues here:
As always, thanks for all the help. I'm catching up slowly... |
That is odd. Can you re-write history so that the pdf and svg tests never existed? |
I'm not entirely sure how to do that, if you don't mind providing an approximate list of steps I'd be grateful. How do you anticipate that would be helpful? |
@lkilcher I can reproduce the error on python3. Basically the problem is that get_styles returns a dictionary of the styles. This no longer has a fixed order and thus the order within the plot changes from run to run on python3. You should probably just make list of the keys and sort this before using this to iterate over the styles to ensure that the order is preserved. |
The simplest is probably
since you are as far as I can see only using the keys. |
The benefit of re writing history so that the other files were never there is to keep the repo size down |
All bbox's in patches.BoxStyle are included in the test image.
Holey smokes! It worked. I went ahead and squashed all of my pep8 fixes and other silly bugs into the main commit. So, now there are just the two commits: the DArrow, and the test. I created the test image with the If anyone has ideas on why I don't have the Bitstream Vera Sans font without this trick, I'd be grateful. |
@mdboom probably would know about the font issues, but he is out for the On Wed, Jul 23, 2014 at 5:53 PM, Levi Kilcher notifications@github.com
|
Thanks, I'll do that. Also, note that I've made a few additional minor changes with this last commit. I think they're pretty logical, but if anyone objects I can remove them. |
Added Circle to annotations_guide.rst. Moved DArrow up so that entries are sorted. Made fancybox_demo2.py outputs sorted box demo (so that ordering matches annotations_guide). Increased spacing between boxes in fancybox_demo2 to prevent overlap of images.
OK, unless anyone has additional requests I think this is ready to go. Thanks again for taking the time to teach me how to contribute to a real project. Hopefully I'll be able to contribute more substantially in the future. |
Everything looks good to me. @tacaswell , did you want to wait a bit for the 1.4.0 dust to clear or just go ahead? |
We have created a branch, we can start doing what ever we want on master again. I'm going to go ahead and merge this. |
This adds a double arrow to BoxStyle class.