BUG : don't assign color to flier props if None #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks right to me. This was the solution that I had in mind too. Perhaps the same should be done for marker just above? So that it is possible to specify the colour but not the marker? The Travis failure is in |
|
I agree, I will get to this later today unless you get to it first. The test should turn into a two panel thing. |
add a guard against `None` returned as `marker` by `_process_plot_format(sym)`.
Adds test for case where `sym` kwarg to `bxp` does not specify color
|
Added second test, rebased and re-wrote history to get rid of the old png. This is the last code PR needed for rc3, then just docs (which we are also almost done with!) |
|
Looks good to me. Lets merge and cut the rc. |
tacaswell
added a commit
that referenced
this pull request
Aug 7, 2014
BUG : don't assign color or marker to flier props if None
|
Merging on review from @jenshnielsen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3336