Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatchCollection: pass other kwargs for match_original=True #3619

Merged
merged 1 commit into from Oct 11, 2014
Merged

PatchCollection: pass other kwargs for match_original=True #3619

merged 1 commit into from Oct 11, 2014

Conversation

duncanmmacleod
Copy link
Contributor

If match_original=True is given to PatchCollection() all keyword arguments are currently ignored. This commit passes all user-given kwargs except those five that are already extracted from the original patches.

This patch closes #3617.

    - match_original should only ignore the following kwargs:
          edgecolors
          facecolors
          linewidths
          linestyles
      all others should be passed onto the Collection constructor
@tacaswell tacaswell added this to the v1.4.x milestone Oct 4, 2014
@tacaswell tacaswell changed the title PatchCollection: pass other kwargs for match_original=True PatchCollection: pass other kwargs for match_original=True [backport to 1.4,x] Oct 4, 2014
@mdboom
Copy link
Member

mdboom commented Oct 5, 2014

👍

tacaswell added a commit that referenced this pull request Oct 11, 2014
PatchCollection: pass other kwargs for match_original=True
@tacaswell tacaswell merged commit 3e15a8e into matplotlib:master Oct 11, 2014
@tacaswell
Copy link
Member

Changed my mind about back-porting this. It is more of a new feature-ish than a bug-ish.

@tacaswell tacaswell changed the title PatchCollection: pass other kwargs for match_original=True [backport to 1.4,x] PatchCollection: pass other kwargs for match_original=True Oct 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PatchCollection.__init__ ignores all kwargs if match_original=True
3 participants