Remove unnecessary pyplot import from axes_grid1 #4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing pyplot to be imported, and the backend
set, as soon as axes_grid1 was imported by anything, including
seemingly unrelated packages like basemap. As a result, one
could not use "matplotlib.use('agg')" after importing basemap.
|
The Travis failure on Python 2.6 is unrelated: |
|
Looks good to me. It looks like pyplot was only imported for the if main examples to run (Which where disabled anyway) |
|
@efiring Do we want to prserve those examples someplace else? |
tacaswell
added a commit
that referenced
this pull request
May 3, 2015
MNT : Remove unnecessary pyplot import from axes_grid1
tacaswell
added a commit
that referenced
this pull request
May 3, 2015
MNT : Remove unnecessary pyplot import from axes_grid1
|
|
|
I didn't really look at the examples; they appeared to be detritus from the development stage. There are axes_grid1 examples in our gallery. @leejjoon, comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing pyplot to be imported, and the backend
set, as soon as axes_grid1 was imported by anything, including
seemingly unrelated packages like basemap. As a result, one
could not use "matplotlib.use('agg')" after importing basemap.
This should be back-ported to color_overhaul.