-
Notifications
You must be signed in to change notification settings - Fork 12.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Free intermediate translation results as soon as possible
This fixes the recently introduced peak memory usage regression by freeing the intermediate results as soon as they're not required anymore instead of keeping them around for the whole compilation process. Refs #8077
- Loading branch information
Showing
1 changed file
with
13 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
075560a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at dotdash@075560a
075560a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging dotdash/rust/peak_mem = 075560a into auto
075560a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotdash/rust/peak_mem = 075560a merged ok, testing candidate = 85b5513
075560a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/608
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/611
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt/builds/613
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt-vg/builds/606
success: http://buildbot.rust-lang.org/builders/auto-mac-all-opt/builds/609
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/627
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt/builds/630
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/627
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt/builds/631
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt-vg/builds/636
success: http://buildbot.rust-lang.org/builders/auto-linux-all-opt/builds/629
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/611
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt/builds/626
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/400
075560a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 85b5513
075560a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmr: Do we have one of your memory plots for this?
075560a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kud1ing, a plot will appear here at some point in the near future.
075560a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(It's there now, and is actually 150 MB lower than it was before the regression.)
075560a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome! Both the patch and the tools :)