Skip to content

Commit

Permalink
syntax: Add the Bug Report HOWTO URL to the ICE message
Browse files Browse the repository at this point in the history
And also reference the bug report HOWTO in CONTRIBUTING.md
  • Loading branch information
catamorphism committed Oct 21, 2013
1 parent cf7b9eb commit 5afd760
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## How to submit a bug report

If you're just reporting a bug, please see:

https://github.com/mozilla/rust/wiki/HOWTO-submit-a-Rust-bug-report

## Pull request procedure

Pull requests should be targeted at Rust's `master` branch.
Expand Down
6 changes: 5 additions & 1 deletion src/libsyntax/diagnostic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ use std::io;
use std::local_data;
use extra::term;

static BUG_REPORT_URL: &'static str =
"https://github.com/mozilla/rust/wiki/HOWTO-submit-a-Rust-bug-report";

pub trait Emitter {
fn emit(&self,
cmsp: Option<(@codemap::CodeMap, Span)>,
Expand Down Expand Up @@ -143,7 +146,8 @@ impl handler for HandlerT {
}
pub fn ice_msg(msg: &str) -> ~str {
format!("internal compiler error: {}", msg)
format!("internal compiler error: {}\nThis message reflects a bug in the Rust compiler. \
\nWe would appreciate a bug report: {}", msg, BUG_REPORT_URL)
}

pub fn mk_span_handler(handler: @mut handler, cm: @codemap::CodeMap)
Expand Down

13 comments on commit 5afd760

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at catamorphism@5afd760

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging catamorphism/rust/bug-report-docs = 5afd760 into auto

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catamorphism/rust/bug-report-docs = 5afd760 merged ok, testing candidate = 2d915e40

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at catamorphism@5afd760

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging catamorphism/rust/bug-report-docs = 5afd760 into auto

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catamorphism/rust/bug-report-docs = 5afd760 merged ok, testing candidate = 530b13c6

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at catamorphism@5afd760

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging catamorphism/rust/bug-report-docs = 5afd760 into auto

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catamorphism/rust/bug-report-docs = 5afd760 merged ok, testing candidate = cd8c7cf

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

@bors
Copy link
Contributor

@bors bors commented on 5afd760 Oct 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = cd8c7cf

Please sign in to comment.