Skip to content

Commit

Permalink
collections: deprecate BTree.
Browse files Browse the repository at this point in the history
This is very half-baked at the moment and very inefficient, e.g.
inappropriate use of by-value `self` (and thus being forced into an
overuse of `clone`). People get the wrong impression about Rust when
using it, e.g. that Rust cannot express what other languages can because
the implementation is inefficient.
  • Loading branch information
huonw committed Aug 17, 2014
1 parent 85fd37f commit 7b141ad
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/libcollections/btree.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
// btree.rs
//

// NB. this is not deprecated for removal, just deprecating the
// current implementation. If the major pain-points are addressed
// (overuse of by-value self and .clone), this can be removed.
#![deprecated = "the current implementation is extremely inefficient, \
prefer a HashMap, TreeMap or TrieMap"]
#![allow(deprecated)]

//! Starting implementation of a btree for rust.
//! Structure inspired by github user davidhalperin's gist.

Expand Down

5 comments on commit 7b141ad

@bors
Copy link
Contributor

@bors bors commented on 7b141ad Aug 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at huonw@7b141ad

@bors
Copy link
Contributor

@bors bors commented on 7b141ad Aug 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging huonw/rust/deprecated-btree = 7b141ad into auto

@bors
Copy link
Contributor

@bors bors commented on 7b141ad Aug 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huonw/rust/deprecated-btree = 7b141ad merged ok, testing candidate = eff87bc

@bors
Copy link
Contributor

@bors bors commented on 7b141ad Aug 17, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = eff87bc

Please sign in to comment.