-
Notifications
You must be signed in to change notification settings - Fork 12.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Factor out foldable better to reduce code duplication. There is now a…
… "double dispatch" pattern that lets you easily write new folders and then apply them to various structures, reusing the "folding" effort.
- Loading branch information
1 parent
0550b79
commit 7d6f1aa
Showing
5 changed files
with
330 additions
and
340 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
7d6f1aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at nikomatsakis@7d6f1aa
7d6f1aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging nikomatsakis/rust/issue-5527-refactor-foldable = 7d6f1aa into auto
7d6f1aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nikomatsakis/rust/issue-5527-refactor-foldable = 7d6f1aa merged ok, testing candidate = 4537f13
7d6f1aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5750
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5749
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/4844
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4852
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5848
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4936
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4944
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5850
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/4935
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4941
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/5003
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2737
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5843
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4939
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4954
7d6f1aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 4537f13