Skip to content

Commit

Permalink
Update the existing compile-fail tests to reflect diagnostic changes …
Browse files Browse the repository at this point in the history
…in NLL.
  • Loading branch information
pnkfelix committed Jun 19, 2018
1 parent 35971cc commit a32fca7
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/test/compile-fail/assign-imm-local-twice.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

fn test() {
let v: isize;
//[mir]~^ NOTE consider changing this to `mut v`
v = 1; //[ast]~ NOTE first assignment
//[mir]~^ NOTE first assignment
println!("v={}", v);
Expand Down
4 changes: 3 additions & 1 deletion src/test/compile-fail/issue-45199.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

fn test_drop_replace() {
let b: Box<isize>;
//[mir]~^ NOTE consider changing this to `mut b`
b = Box::new(1); //[ast]~ NOTE first assignment
//[mir]~^ NOTE first assignment
b = Box::new(2); //[ast]~ ERROR cannot assign twice to immutable variable
Expand All @@ -24,14 +25,15 @@ fn test_drop_replace() {
fn test_call() {
let b = Box::new(1); //[ast]~ NOTE first assignment
//[mir]~^ NOTE first assignment
//[mir]~| NOTE consider changing this to `mut b`
b = Box::new(2); //[ast]~ ERROR cannot assign twice to immutable variable
//[mir]~^ ERROR cannot assign twice to immutable variable `b`
//[ast]~| NOTE cannot assign twice to immutable
//[mir]~| NOTE cannot assign twice to immutable
}

fn test_args(b: Box<i32>) { //[ast]~ NOTE first assignment
//[mir]~^ NOTE argument not declared as `mut`
//[mir]~^ NOTE consider changing this to `mut b`
b = Box::new(2); //[ast]~ ERROR cannot assign twice to immutable variable
//[mir]~^ ERROR cannot assign to immutable argument `b`
//[ast]~| NOTE cannot assign twice to immutable
Expand Down
1 change: 1 addition & 0 deletions src/test/compile-fail/liveness-assign-imm-local-in-loop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

fn test() {
let v: isize;
//[mir]~^ NOTE consider changing this to `mut v`
loop {
v = 1; //[ast]~ ERROR cannot assign twice to immutable variable
//[mir]~^ ERROR cannot assign twice to immutable variable `v`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

fn test() {
let v: isize;
//[mir]~^ NOTE consider changing this to `mut v`
v = 2; //[ast]~ NOTE first assignment
//[mir]~^ NOTE first assignment
v += 1; //[ast]~ ERROR cannot assign twice to immutable variable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
fn test() {
let b = Box::new(1); //[ast]~ NOTE first assignment
//[mir]~^ NOTE first assignment
//[mir]~| NOTE consider changing this to `mut b`
drop(b);
b = Box::new(2); //[ast]~ ERROR cannot assign twice to immutable variable
//[mir]~^ ERROR cannot assign twice to immutable variable `b`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
fn test() {
let v: isize = 1; //[ast]~ NOTE first assignment
//[mir]~^ NOTE first assignment
//[mir]~| NOTE consider changing this to `mut v`
v.clone();
v = 2; //[ast]~ ERROR cannot assign twice to immutable variable
//[mir]~^ ERROR cannot assign twice to immutable variable `v`
Expand Down

0 comments on commit a32fca7

Please sign in to comment.