Skip to content

Commit

Permalink
Reexport static trait methods on traits in the same module.
Browse files Browse the repository at this point in the history
  • Loading branch information
thomaslee committed May 20, 2013
1 parent ebdb0de commit e02716e
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/librustc/metadata/encoder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,10 @@ fn encode_reexported_static_methods(ecx: @EncodeContext,
match ecx.tcx.trait_methods_cache.find(&exp.def_id) {
Some(methods) => {
match ecx.tcx.items.find(&exp.def_id.node) {
Some(&ast_map::node_item(_, path)) => {
if mod_path != *path {
Some(&ast_map::node_item(item, path)) => {
let interner = ecx.tcx.sess.parse_sess.interner;
let original_name = ecx.tcx.sess.str_of(item.ident);
if mod_path != *path || *exp.name != *original_name {
for methods.each |&m| {
if m.explicit_self == ast::sty_static {
encode_reexported_static_method(ecx,
Expand Down
10 changes: 10 additions & 0 deletions src/test/auxiliary/mod_trait_with_static_methods_lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@
// except according to those terms.

pub use sub_foo::Foo;
pub use Baz = self::Bar;

pub trait Bar {
pub fn bar() -> Self;
}

impl Bar for int {
pub fn bar() -> int { 84 }
}

pub mod sub_foo {
pub trait Foo {
Expand All @@ -18,4 +27,5 @@ pub mod sub_foo {
impl Foo for int {
pub fn foo() -> int { 42 }
}

}
2 changes: 2 additions & 0 deletions src/test/run-pass/trait_with_static_methods_cross_crate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
extern mod mod_trait_with_static_methods_lib;

use mod_trait_with_static_methods_lib::Foo;
use mod_trait_with_static_methods_lib::Baz;

pub fn main() {
assert_eq!(42, Foo::foo());
assert_eq!(84, Baz::bar());
}

0 comments on commit e02716e

Please sign in to comment.