Skip to content

Commit

Permalink
Fixed Win64 build
Browse files Browse the repository at this point in the history
  • Loading branch information
vadimcn committed Apr 23, 2014
1 parent 6619134 commit f686e5e
Show file tree
Hide file tree
Showing 7 changed files with 105 additions and 44 deletions.
15 changes: 2 additions & 13 deletions src/libgreen/macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,20 +52,9 @@ macro_rules! rtabort (

pub fn dumb_println(args: &fmt::Arguments) {
use std::io;
use libc;
use std::rt;

struct Stderr;
impl io::Writer for Stderr {
fn write(&mut self, data: &[u8]) -> io::IoResult<()> {
unsafe {
libc::write(libc::STDERR_FILENO,
data.as_ptr() as *libc::c_void,
data.len() as libc::size_t);
}
Ok(()) // just ignore the result
}
}
let mut w = Stderr;
let mut w = rt::Stderr;
let _ = fmt::writeln(&mut w as &mut io::Writer, args);
}

Expand Down
15 changes: 2 additions & 13 deletions src/librustuv/macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,19 +29,8 @@ macro_rules! uvdebug (

pub fn dumb_println(args: &fmt::Arguments) {
use std::io;
use libc;
use std::rt;

struct Stderr;
impl io::Writer for Stderr {
fn write(&mut self, data: &[u8]) -> io::IoResult<()> {
let _ = unsafe {
libc::write(libc::STDERR_FILENO,
data.as_ptr() as *libc::c_void,
data.len() as libc::size_t)
};
Ok(()) // just ignore the errors
}
}
let mut w = Stderr;
let mut w = rt::Stderr;
let _ = fmt::writeln(&mut w as &mut io::Writer, args);
}
16 changes: 2 additions & 14 deletions src/libstd/io/stdio.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ out.write(bytes!("Hello, world!"));
*/

use container::Container;
use fmt;
use io::{Reader, Writer, IoResult, IoError, OtherIoError,
standard_error, EndOfFile, LineBufferedWriter, BufferedReader};
Expand All @@ -37,11 +36,11 @@ use mem::replace;
use option::{Option, Some, None};
use prelude::drop;
use result::{Ok, Err};
use rt;
use rt::local::Local;
use rt::rtio::{DontClose, IoFactory, LocalIo, RtioFileStream, RtioTTY};
use rt::task::Task;
use str::StrSlice;
use slice::ImmutableVector;

// And so begins the tale of acquiring a uv handle to a stdio stream on all
// platforms in all situations. Our story begins by splitting the world into two
Expand Down Expand Up @@ -236,18 +235,7 @@ fn with_task_stdout(f: |&mut Writer| -> IoResult<()> ) {
}

None => {
struct Stdout;
impl Writer for Stdout {
fn write(&mut self, data: &[u8]) -> IoResult<()> {
unsafe {
libc::write(libc::STDOUT_FILENO,
data.as_ptr() as *libc::c_void,
data.len() as libc::size_t);
}
Ok(()) // just ignore the results
}
}
let mut io = Stdout;
let mut io = rt::Stdout;
f(&mut io as &mut Writer)
}
};
Expand Down
83 changes: 83 additions & 0 deletions src/libstd/rt/backtrace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,89 @@ mod imp {
}
}

#[cfg(target_arch = "x86_64")]
mod arch {
use libc::{c_longlong, c_ulonglong};
use libc::types::os::arch::extra::{WORD, DWORD, DWORDLONG};

pub struct CONTEXT {
P1Home: DWORDLONG,
P2Home: DWORDLONG,
P3Home: DWORDLONG,
P4Home: DWORDLONG,
P5Home: DWORDLONG,
P6Home: DWORDLONG,

ContextFlags: DWORD,
MxCsr: DWORD,

SegCs: WORD,
SegDs: WORD,
SegEs: WORD,
SegFs: WORD,
SegGs: WORD,
SegSs: WORD,
EFlags: DWORD,

Dr0: DWORDLONG,
Dr1: DWORDLONG,
Dr2: DWORDLONG,
Dr3: DWORDLONG,
Dr6: DWORDLONG,
Dr7: DWORDLONG,

Rax: DWORDLONG,
Rcx: DWORDLONG,
Rdx: DWORDLONG,
Rbx: DWORDLONG,
Rsp: DWORDLONG,
Rbp: DWORDLONG,
Rsi: DWORDLONG,
Rdi: DWORDLONG,
R8: DWORDLONG,
R9: DWORDLONG,
R10: DWORDLONG,
R11: DWORDLONG,
R12: DWORDLONG,
R13: DWORDLONG,
R14: DWORDLONG,
R15: DWORDLONG,

Rip: DWORDLONG,

FltSave: FLOATING_SAVE_AREA,

VectorRegister: [M128A, .. 26],
VectorControl: DWORDLONG,

DebugControl: DWORDLONG,
LastBranchToRip: DWORDLONG,
LastBranchFromRip: DWORDLONG,
LastExceptionToRip: DWORDLONG,
LastExceptionFromRip: DWORDLONG,
}

pub struct M128A {
Low: c_ulonglong,
High: c_longlong
}

pub struct FLOATING_SAVE_AREA {
_Dummy: [u8, ..512] // FIXME: Fill this out
}

pub fn init_frame(frame: &mut super::STACKFRAME64,
ctx: &CONTEXT) -> DWORD {
frame.AddrPC.Offset = ctx.Rip as u64;
frame.AddrPC.Mode = super::AddrModeFlat;
frame.AddrStack.Offset = ctx.Rsp as u64;
frame.AddrStack.Mode = super::AddrModeFlat;
frame.AddrFrame.Offset = ctx.Rbp as u64;
frame.AddrFrame.Mode = super::AddrModeFlat;
super::IMAGE_FILE_MACHINE_AMD64
}
}

struct Cleanup {
handle: libc::HANDLE,
SymCleanup: SymCleanupFn,
Expand Down
2 changes: 2 additions & 0 deletions src/libstd/rt/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ pub use self::util::default_sched_threads;
// Export unwinding facilities used by the failure macros
pub use self::unwind::{begin_unwind, begin_unwind_raw, begin_unwind_fmt};

pub use self::util::{Stdio, Stdout, Stderr};

// FIXME: these probably shouldn't be public...
#[doc(hidden)]
pub mod shouldnt_be_public {
Expand Down
16 changes: 12 additions & 4 deletions src/libstd/rt/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,22 @@ pub fn default_sched_threads() -> uint {
}
}

pub struct Stderr;
pub struct Stdio(libc::c_int);

impl io::Writer for Stderr {
pub static Stdout: Stdio = Stdio(libc::STDOUT_FILENO);
pub static Stderr: Stdio = Stdio(libc::STDERR_FILENO);

impl io::Writer for Stdio {
fn write(&mut self, data: &[u8]) -> IoResult<()> {
#[cfg(unix)]
type WriteLen = libc::size_t;
#[cfg(windows)]
type WriteLen = libc::c_uint;
unsafe {
libc::write(libc::STDERR_FILENO,
let Stdio(fd) = *self;
libc::write(fd,
data.as_ptr() as *libc::c_void,
data.len() as libc::size_t);
data.len() as WriteLen);
}
Ok(()) // yes, we're lying
}
Expand Down
2 changes: 2 additions & 0 deletions src/libstd/unstable/mutex.rs
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,8 @@ mod imp {
static SPIN_COUNT: DWORD = 4000;
#[cfg(target_arch = "x86")]
static CRIT_SECTION_SIZE: uint = 24;
#[cfg(target_arch = "x86_64")]
static CRIT_SECTION_SIZE: uint = 40;

pub struct Mutex {
// pointers for the lock/cond handles, atomically updated
Expand Down

7 comments on commit f686e5e

@alexcrichton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, awesome!

@alexcrichton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@bors
Copy link
Contributor

@bors bors commented on f686e5e Apr 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at vadimcn@f686e5e

@bors
Copy link
Contributor

@bors bors commented on f686e5e Apr 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging vadimcn/rust/Win64-pre = f686e5e into auto

@bors
Copy link
Contributor

@bors bors commented on f686e5e Apr 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vadimcn/rust/Win64-pre = f686e5e merged ok, testing candidate = 1ce0b98

@bors
Copy link
Contributor

@bors bors commented on f686e5e Apr 23, 2014

@bors
Copy link
Contributor

@bors bors commented on f686e5e Apr 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 1ce0b98

Please sign in to comment.