debuginfo: Support for generic functions and self arguments #8554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined behavior.
Conflicts: src/librustc/lib/llvm.rs src/librustc/middle/trans/debuginfo.rs src/rustllvm/RustWrapper.cpp src/rustllvm/rustllvm.def.in
Also, always set no_monomorphic_collapse flags if debuginfo is generated.
…d tuple-structs. Also new test cases for tuple structs and by-value parameter passing.
…ds with default implementation.
…tions: * closure-in-generic-function * generic-functions-nested * generic-method-on-generic-struct * generic-trait-generic-static-default-method * method-on-generic-struct * self-in-generic-default-method * trait-generic-static-default-method Also, fixed an 'unused variable' warning in debuginfo.rs
|
wowie ❗ |
|
Well this is just awesome. I love that it's mostly self-contained in debuginfo.rs and comes with a felt-ton of test cases. |
bors
added a commit
that referenced
this pull request
Aug 17, 2013
This pull request includes support for generic functions and self arguments in methods, and combinations thereof. This also encompasses any kind of trait methods, regular and static, with and without default implementation. The implementation is backed up by a felt ton of test cases `:)` This is a very important step towards being able to compile larger programs with debug info, since practically any generic function caused an ICE before. One point worth discussing is that activating debug info now automatically (and silently) sets the `no_monomorphic_collapse` flag. Otherwise debug info would show wrong type names in all but one instance of the monomorphized function. Another thing to note is that the handling of generic types does not strictly follow the DWARF specification. That is, variables with type `T` (where `T=int`) are described as having type `int` and not as having type `T`. In other words, we are losing information whether a variable has been declared with a type parameter as its type. In practice this should not make much of difference though since the concrete type is mostly what one is interested in. I'll post an issue later so this won't be forgotten. Also included are a number of bug fixes: * Closes #1758 * Closes #8513 * Closes #8443 * Fixes handling of field names in tuple structs * Fixes and re-enables test case for option-like enums that relied on undefined behavior before * Closes #1339 (should have been closed a while ago) Cheers, Michael
|
Superb! Amazing! 🍰 😹 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes support for generic functions and self arguments in methods, and combinations thereof. This also encompasses any kind of trait methods, regular and static, with and without default implementation. The implementation is backed up by a felt ton of test cases
:)This is a very important step towards being able to compile larger programs with debug info, since practically any generic function caused an ICE before.
One point worth discussing is that activating debug info now automatically (and silently) sets the
no_monomorphic_collapseflag. Otherwise debug info would show wrong type names in all but one instance of the monomorphized function.Another thing to note is that the handling of generic types does not strictly follow the DWARF specification. That is, variables with type
T(whereT=int) are described as having typeintand not as having typeT. In other words, we are losing information whether a variable has been declared with a type parameter as its type. In practice this should not make much of difference though since the concrete type is mostly what one is interested in. I'll post an issue later so this won't be forgotten.Also included are a number of bug fixes:
Cheers,
Michael