-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove unnecessary ClipDisplayItems in box_.rs
For ScannedTextBox and ImageBox, the ClipDisplayItem's child_list is currently always empty. ClipDisplayItem is used to implement overflow hidden and should only be created for block containers, as per http://www.w3.org/TR/CSS2/visufx.html#propdef-overflow Take care of the case when a BlockFlow has no children display items - like an ImageBox with "display: block".
- Loading branch information
Showing
2 changed files
with
49 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35a869d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from larsbergstrom, larsbergstrom
at pradeep90@35a869d
35a869d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging pradeep90/servo/stacking-context = 35a869d into auto
35a869d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pradeep90/servo/stacking-context = 35a869d merged ok, testing candidate = 5b93bc7
35a869d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/907
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/862
35a869d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 5b93bc7