-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update remove_tile, add automatic tile removal, fix tests for quadtree
- Loading branch information
eschweic
committed
Jul 17, 2013
1 parent
3bb4713
commit 5468885
Showing
3 changed files
with
200 additions
and
123 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
5468885
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from pcwalton
at eschweic@5468885
5468885
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging eschweic/servo/del-tiles = 5468885 into auto
5468885
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eschweic/servo/del-tiles = 5468885 merged ok, testing candidate = c17ede3
5468885
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/138
http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/93
5468885
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = c17ede3
5468885
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I tested this commit, It may exists some memory leakage at the time of tile removal.
5468885
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aydinkim Textures seem to be deleting correctly according to the OpenGL Profiler. Where do you see the leak?