Skip to content

Commit

Permalink
Do not start up webvr services when running webxr and vice versa
Browse files Browse the repository at this point in the history
  • Loading branch information
Manishearth committed Jul 31, 2019
1 parent 174bcc4 commit 5ab40e9
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions components/servo/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -381,16 +381,20 @@ where
// can't defer it after `create_constellation` has started.
script::init();

if pref!(dom.webxr.enabled) && pref!(dom.webvr.enabled) {
panic!("We don't currently support running both WebVR and WebXR");
}

// For the moment, we enable use both the webxr crate and the rust-webvr crate,
// but we are migrating over to just using webxr.
let mut webxr_main_thread = webxr_api::MainThreadRegistry::new(event_loop_waker)
.expect("Failed to create WebXR device registry");
if pref!(dom.webvr.enabled) || pref!(dom.webxr.enabled) {
if pref!(dom.webxr.enabled) {
embedder.register_webxr(&mut webxr_main_thread);
}

let mut webvr_heartbeats = Vec::new();
let webvr_services = if pref!(dom.webvr.enabled) || pref!(dom.webxr.enabled) {
let webvr_services = if pref!(dom.webvr.enabled) {
let mut services = VRServiceManager::new();
services.register_defaults();
embedder.register_vr_services(&mut services, &mut webvr_heartbeats);
Expand Down

0 comments on commit 5ab40e9

Please sign in to comment.