Follow the spec in giving blobs a 'blob' name attribute

servo · Apr 10, 2017 · 912ac62 · 912ac62
1 parent b5722e5
commit 912ac62
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/components/script/dom/formdata.rs b/components/script/dom/formdata.rs
@@ -7,6 +7,7 @@ use dom::bindings::codegen::Bindings::FormDataBinding::FormDataMethods;
 use dom::bindings::codegen::Bindings::FormDataBinding::FormDataWrap;
 use dom::bindings::codegen::UnionTypes::FileOrUSVString;
 use dom::bindings::error::Fallible;
+use dom::bindings::inheritance::Castable;
 use dom::bindings::iterable::Iterable;
 use dom::bindings::js::Root;
 use dom::bindings::reflector::{DomObject, Reflector, reflect_dom_object};
@@ -79,7 +80,7 @@ impl FormDataMethods for FormData {
         let datum = FormDatum {
             ty: DOMString::from("file"),
             name: DOMString::from(name.0.clone()),
-            value: FormDatumValue::File(Root::from_ref(&*self.get_file(blob, filename))),
+            value: FormDatumValue::File(Root::from_ref(&*self.create_an_entry(blob, filename))),
         };
 
         let mut data = self.data.borrow_mut();
@@ -137,17 +138,20 @@ impl FormDataMethods for FormData {
         self.data.borrow_mut().insert(LocalName::from(name.0.clone()), vec![FormDatum {
             ty: DOMString::from("file"),
             name: DOMString::from(name.0),
-            value: FormDatumValue::File(Root::from_ref(&*self.get_file(blob, filename))),
+            value: FormDatumValue::File(Root::from_ref(&*self.create_an_entry(blob, filename))),
         }]);
     }
 
 }
 
 
 impl FormData {
-    fn get_file(&self, blob: &Blob, opt_filename: Option<USVString>) -> Root<File> {
+    // https://xhr.spec.whatwg.org/#create-an-entry
+    // Steps 3-4.
+    fn create_an_entry(&self, blob: &Blob, opt_filename: Option<USVString>) -> Root<File> {
         let name = match opt_filename {
             Some(filename) => DOMString::from(filename.0),
+            None if blob.downcast::<File>().is_none() => DOMString::from("blob"),
             None => DOMString::from(""),
         };
 

diff --git a/tests/wpt/metadata/XMLHttpRequest/formdata-blob.htm.ini b/tests/wpt/metadata/XMLHttpRequest/formdata-blob.htm.ini