fix(ncyBreadcrumb): Prevent memory leak when label is a binding #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Releases collection of watchers, preventing a leak when the label is a binding and not a string
|
Hi, thank you for your PR. Shame of me, arrays are passed by value of course 😅 |
ncuillery
added a commit
that referenced
this pull request
May 14, 2015
fix(ncyBreadcrumb): Prevent memory leak when label is a binding
|
You've built an excellent tool, we're happy to contribute where we can :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releases collection of watchers, preventing a leak when the label is a binding and not a string.
We found that when using ui-router state definitions, if we used a binding (pictured below) and not a string constant, the related scope is leaked and held onto. The
deregisterWatchers()function does not actually clear out the collection passed in. This causes the functions in the collections to accumulate, and in this scenario they hold references to scopes.Clearing out the collections in the calling functions releases the references as expected.