Crash on Mac OS Monterey 12.7.5 (Intel) - Nicotine+ Version: 3.3.5.dev1

[iioniis]

Nicotine+ Version: 3.3.5.dev1
GTK Version: 4.14.4
Python Version: 3.12.3 (darwin)

Type: <class 'OSError'>
Value: [Errno 22] Invalid argument
Traceback: File "/Users/runner/work/nicotine-plus/nicotine-plus/pynicotine/gtkgui/application.py", line 886, in _raise_exception
File "/usr/local/Cellar/python@3.12/3.12.3/Frameworks/Python.framework/Versions/3.12/lib/python3.12/threading.py", line 1073, in _bootstrap_inner
File "/Users/runner/work/nicotine-plus/nicotine-plus/pynicotine/slskproto.py", line 2732, in run
File "/Users/runner/work/nicotine-plus/nicotine-plus/pynicotine/slskproto.py", line 2497, in _process_ready_sockets
File "/Users/runner/work/nicotine-plus/nicotine-plus/pynicotine/slskproto.py", line 2400, in _process_ready_input_socket
Operating System/Distribution:

I wasn't active at the computer when it happened. I just came back to this report.

[slook]

Thank you for your bug report :)

It is caused by recent commit e181f50

nicotine-plus/pynicotine/slskproto.py

Line 2400 in 77bc46d

incoming_sock.setsockopt(socket.SOL_SOCKET, socket.SO_RCVBUF, self.SOCKET_READ_BUFFER_SIZE)

[mathiascode]

Maybe an incoming connection died while accepting it? Are you able to perform file searches without issues?

[iioniis]

Maybe an incoming connection died while accepting it? Are you able to perform file searches without issues?

mathiascode, yes I am. Search seams to work fine. It's only happened when I'm not actively using it and uploads are going. Uploads are usually happening anyway and it doesn't crash all the time.

[slook]

It is bizarre that this argument is available on the system (otherwise the program wouldn't even be able to start), yet for some reason it went away in the middle of a session.

It's only happened when I'm not actively using it

I suppose the interface could have gone down for sleep or something like that.

[mathiascode]

I'll have to verify how macOS behaves myself, but the fix will most likely be to move the setsockopt calls inside the try block.

[mathiascode]

I haven't been able to reproduce this issue on macOS. All incoming connections are working fine.

I don't know what the exact issue is, but it's an edge case. I'll catch the exception and remove such connections.