-
-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect text being typed in some text fields with braille on #4291
Comments
Attachment without_braille.txt added by pitermach on 2014-07-14 11:30 |
Attachment with_braille.txt added by pitermach on 2014-07-14 11:31 |
Comment 2 by jteh on 2014-07-15 01:57 A work around is to disable all font, color and style options, as well as reporting of links, in Document Formatting settings. Technical: This occurs because the only way we can get formatting for RichEdit controls via window messages is to move the selection, but moving the selection while the user is typing obviously causes weirdness. We can use ITextDocument instead which doesn't have this issue, but ITextDocument is very slow on Windows XP (not sure about Vista), so we'd only want to do this in Windows 7 and later. |
Comment 3 by pitermach on 2014-07-15 08:38 |
Comment 5 by jteh on 2015-07-15 09:27 |
Comment 7 by jteh on 2015-07-15 09:44 |
Comment 8 by dkager on 2015-07-15 15:23
If I then uncheck all options in the document formatting settings I can't reproduce this at all. This snapshot doesn't have the fix mentioned in comment:6, so will test again tomorrow. |
Comment 9 by dkager on 2015-07-17 08:56 |
Comment 10 by jteh on 2015-07-17 12:21 |
Comment 11 by dkager on 2015-07-18 08:37 Dev info:
|
Comment 12 by James Teh <jamie@... on 2015-07-23 06:25
Changes:
|
Comment 13 by jteh on 2015-07-23 06:27 Please try the "next" branch snapshot for 23 July, which should be up in about 3 hours. |
Comment 14 by dkager (in reply to comment 12) on 2015-07-23 16:13 |
Comment 15 by msuch on 2015-07-23 16:48 |
Comment 16 by jteh on 2015-07-23 23:34 |
Comment 17 by jteh on 2015-07-23 23:37 |
Comment 18 by leonarddr (in reply to comment 14) on 2015-07-28 13:14
Same here, thanks for this fix! |
Comment 19 by James Teh <jamie@... on 2015-07-31 03:16
Changes:
|
…ain applications such as Wordpad and Skype with a braille display. This is related to Rich Edit controls. It occurred because in order to get formatting information in these controls, we have to move the selection (and thus the cursor), which obviously causes problems if typed characters are arriving during this process. To fix this, we can use ITextDocument. We previously disabled this due to poor performance, but it seems this is fixed in Windows 7 and later. Therefore, use ITextDocument in Windows 7 and later. Also, the previous code for detecting links in ITextDocument still moved the selection. However, ITextDocument provides for another way to detect links which doesn't do this. Fixes #4291.
Reported by pitermach on 2014-07-14 11:29
If I have a braille display connected (HumanWare Brailliant BI in my case, although I spoke to a user of a baum display who also noticed this), in some rich text fields something causes Windows not to type the text in properly even though the keys seem to be registered fine. I know this is definitely happening in Wordpad, Skype, Tween, but notepad doesn't seem to be effected. I have attached 2 logs, one where I type in a text sentence without the display connected, and one where I do. In the second case I type it in multiple times and every time I get a slightly different result - once everything gets really mangled, another time it got typed fine and in another a space went missing. This was done in a blank wordpad file on Windows 8.1. The only way I found to avoid this is to type really slowly or disconnect the braille display when typing a lot, which is very inpractical.
The text was updated successfully, but these errors were encountered: