forked from jayallen/melody
-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Post-Merge fixes: mod_perl isn't the only persistent environment. Fas…
…tCGI should also get the message to restart the webserver after switching plugins on/off
- Loading branch information
Showing
3 changed files
with
9 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c78c933
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good change, but needs a bit more to support dispatchers.
Support for the fact that some fastcgi implementations will auto restart.
Support for the fact that some fastcgi implementations are restarted independent of the webserver.
needs_restart => ( !$ENV{NO_RESTART} && ( $ENV{MOD_PERL} || $ENV{FAST_CGI} )),
This way the restart message can be overridden.
The phrase itself needs to say something like "you will need to restart your web server or persistent application environment ..."
c78c933
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points all around, Reed. Should I expect a pull request from you or were you asking me to make these changes?
c78c933
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how to use git, so it would be nice if you could make the changes.
c78c933
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'd be happy to. Just in case you weren't aware, though, you can fork the code and edit it completely through the GitHub website without ever using Git (see http://skitch.com/jayallen/dc6bq/editing-through-github-s-website). Or you could use Subversion (see http://svn.github.com/openmelody/melody). Or, you could just provide us with a patch. Lots of ways to participate if you don't want to git with Git.