-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.10.3 layout #691
Comments
Can you paste the stacktrace? very likely a sinatra change we didn't account for, will investigate the issue soon. |
Sure, is this what you're looking for?
|
Here's the line that causes your issue: # application/rendering.rb:273
logger.debug :template, began_at, located_template[0] if settings.logging? && defined?(logger) Looks like @EtienneLem just to confirm can you reproduce the error then change the |
Oh! |
Hi again, newbie here - having this trouble too in the blog app. I tweaked padrino to skip "if located_template is false" but it's good to know I can roll-back my tweak and simply disable logging. Every 'render' call was failing. (My change which I plan to throw away: |
@DAddYE we may have to do a hotfix release for this issue and the flash one. How did we not get bitten with this template issue before release :(? |
Here's the commit that unfortunately caused this: acc1d6a for reference. Going to add an existence check to fix it now. Any ideas on how we can improve our test coverage so we can catch these types of things more easily? |
Yeah, me again.
Looks like the new version requires a layout? It now throws a bug when there's no
views/application.erb
where it wouldn't on v 0.10.2.Is this something new with the latest Sinatra, or it is related to Padrino (bug or new feature)?
In any case,
views/application.erb
(depending on the renderer, of course) could be automatically created when generating a project.The text was updated successfully, but these errors were encountered: