Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NF-solar] power of curved solar panels #6

Open
pellinor0 opened this issue Jun 12, 2015 · 1 comment
Open

[NF-solar] power of curved solar panels #6

pellinor0 opened this issue Jun 12, 2015 · 1 comment

Comments

@pellinor0
Copy link
Owner

Power generation does not scale. This is the exponent I use:

TWEAKSCALEEXPONENTS:NEEDS[NearFutureSolar]
{
    name = ModuleCurvedSolarPanel
    TotalEnergyRate = 2
}
@pellinor0
Copy link
Owner Author

I had a look in
https://github.com/ChrisAdderley/NearFutureSolar/blob/master/ModuleCurvedSolarPanel.cs

The problem seems to be that TotalEnergyRate is used only once to calculate chargePerTransform, probably this is done before TweakScale tries to scale it. chargePerTransform can not be scaled because it is not a kspField.

In my opinion this is best solved in NF-Solar, by evaluating TotalEnergyRate directly in the fixedUpdate method.

EDIT: I am working on a pull request for NF-Solar

@pellinor0 pellinor0 changed the title power of NF-solar curved solar panels [NF-solar] power of curved solar panels May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant