Fixed handling of traits #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this patch and it fixes PHPMD handling of Traits. Without this patch I get the following error: PHP Catchable fatal error: Argument 1 passed to PHP_PMD_Node_Interface::__construct() must be an instance of PHP_Depend_Code_Interface, instance of PHP_Depend_Code_Trait given, called in /usr/share/php/PHP/PMD/Node/Method.php on line 134 and defined in /usr/share/php/PHP/PMD/Node/Interface.php on line 75 Full backtrace output at: http://www.adamashley.name/stuff/phpmd-output.txt |
|
I've tested this code, and can also confirm that it fixes the issues detailed in http://www.adamashley.name/stuff/phpmd-output.txt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some issues when trying to do mess detection of traits. This pull request is a (possibly) naive fix for that issue.
NB: this does depend on the following PR for pdepend https://github.com/manuelpichler/pdepend/pull/11