Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ok_manifest reports duplicate files on internal symlinks #7

Closed
andk opened this issue Jun 29, 2017 · 0 comments
Closed

ok_manifest reports duplicate files on internal symlinks #7

andk opened this issue Jun 29, 2017 · 0 comments

Comments

@andk
Copy link

andk commented Jun 29, 2017

Witness the following sequence of commands in a shell starting in an empty directory. ok_manifest complains about A.txt appearing more than once. The bug is to count the target of the symlink.

% mkdir somedir
% date > somedir/A.txt
% ln -s A.txt somedir/B.txt
% perl -e 'use ExtUtils::Manifest; ExtUtils::Manifest::mkmanifest'
Added to MANIFEST: MANIFEST
Added to MANIFEST: somedir/A.txt
Added to MANIFEST: somedir/B.txt
% perl -e 'use Test::CheckManifest; ok_manifest();'
1..1
not ok 1
#   Failed test at -e line 1.
#          got: 0
#     expected: 1
# The following files appeared more than once in the MANIFEST file: /home/andk/work/bugreport-Test-CheckManifest/somedir/A.txt
# Looks like you failed 1 test of 1.

Enjoy&&Regards,

alvar-freude added a commit to tls-check/TLS-Check that referenced this issue Jan 25, 2018
Skip all,  because test::CheckManifest counts symlinked files as duplicates!
Issue reneeb/Test-CheckManifest#7
alvar-freude added a commit to tls-check/TLS-Check that referenced this issue Jan 25, 2018
Skip manifest check, because Test::CheckManifest counts symlinks as duplicates

Issue: reneeb/Test-CheckManifest#7
@reneeb reneeb closed this as completed in f582165 Jan 26, 2018
alvar-freude added a commit to tls-check/TLS-Check that referenced this issue Feb 22, 2018
Symlink bug fixed in Test::CheckManifest 1.33

reneeb/Test-CheckManifest#7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant