-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken on Windows #9
Comments
I can confirm that it does not pass test under strawberry. removing the test at line 49 (and changing the plan to 8 tests) it PASS: I have to investigate further |
the problem with the above test 'filter OR exclude' happens just after "file with spaces" is processed. this make me suspicious. Infact the file giving the error is testrules.yaml the yaml file is in @files but not in @dir_files But the filtering part seems too complicated for me.. so i cannot see atm where it fails |
removing the file testrules.yml from its original position and from MANIFEST the test PASS |
Thanks for your analysis. I think I've spotted a bug... I will release a new version this evening. |
@LorenzoTa Can you please check version 1.35? Thanks |
i'm working on 1.35 (even if the folder is misnamed) shell>perl -I ./lib -MTest::CheckManifest -E "say $Test::CheckManifest::VERSION" 1.35 But.. no hope. I have problem to understand the filter part, but all call to I fear that to compare dastructures you must use is_deeply against @$folders obtained by File::Spec->splitpath shell>prove -l -v ./t/01_selftest.t ./t/01_selftest.t .. 1..10 ok 1 - expected: Manifest not ok # Failed test 'Filter: \.(?:svn|git|build)' not ok 2 - Filter: \.(?:svn|git|build)# at ./t/01_selftest.t line 41. # got: 0 # expected: 1 # The following files are not named in the MANIFEST file: D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\CONTRIBUTING.md, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\README.mkdn, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\02_validate_args.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\03_find_home.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\04_check_excludes.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\05_is_excluded.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\06_bailout.t ok 3 - expected: Manifest not ok (Exclude /.git/) ok 4 - Filter: \.svn ok 5 - expected: Manifest not ok (Exclude /.git/) [2] ok 6 - expected: Manifest not ok (exclude OR filter) ok 7 - filter AND exclude ok 8 - filter OR exclude - test.svn is missing in MANIFEST not ok 9 - filter OR exclude# Failed test 'filter OR exclude' # at ./t/01_selftest.t line 61. # got: 0 # expected: 1 # The following files are not named in the MANIFEST file: D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\CONTRIBUTING.md, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\README.mkdn, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\02_validate_args.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\03_find_home.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\04_check_excludes.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\05_is_excluded.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\06_bailout.t # Failed test 'Filter \.git or \.svn' not ok 10 - Filter \.git or \.svn # at ./t/01_selftest.t line 68. # got: 0 # expected: 1 # The following files are not named in the MANIFEST file: D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\CONTRIBUTING.md, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\README.mkdn, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\02_validate_args.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\03_find_home.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\04_check_excludes.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\05_is_excluded.t, D:\ulisseDUE\Test-CheckManifest1.34\Test-CheckManifest-master\t\06_bailout.t # Looks like you failed 3 tests of 10. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/10 subtests Test Summary Report ------------------- ./t/01_selftest.t (Wstat: 768 Tests: 10 Failed: 3) Failed tests: 2, 9-10 Non-zero exit status: 3 Files=1, Tests=10, 1 wallclock secs ( 0.03 usr + 0.01 sys = 0.05 CPU) Result: FAIL shell> I hope i'll have more time to debug it next days |
I've just released version 1.35 |
i'm now try to fix 05_is_excluded.t that fails with Use of uninitialized value $home in quotemeta at line 264 What _find_home is expected to return? just the directory where the current $0 is running? |
I already fixed that "uninitialized" warning... I work on that test as well. _find_home should return the directory where the MANIFEST is located... |
just a note: |
No worries... Thanks for your PR. It helps a lot. |
This should be fixed in the meantime. The CI pipeline doesn't spot an error... |
When attempting to install on Win10 (x64) with Strawberry Perl 5.28.0.1, it appears to be failing a few tests. I assume these failures are do to DOS shortnames being in use.
The text was updated successfully, but these errors were encountered: