Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support options to always use LVM mode even if the disk is allow for raw mode #14151

Closed
chenyuanrun opened this issue May 2, 2024 · 4 comments

Comments

@chenyuanrun
Copy link

In allowRawMode@pkg/daemon/ceph/osd/volume.go , rook prefer raw mode for disk if it is allowed. In some case we want always use lvm mode to prepare osd (as the name of disk may chang across reboot), can we add a option (something like preferLvm) and use lvm mode if this option is provided?

Is this a bug report or feature request?

  • Feature Request

What should the feature do:

What is use case behind this feature:

Environment:

@travisn
Copy link
Member

travisn commented May 3, 2024

If the disk is labeled, the raw mode is expected to be stable for OSDs even if the disks are renamed on reboot. We wanted to avoid LVM mode because there were challenges with stability with the LVs and proper provisioning and shutdown. Given our negative experiences with LVM in the past, I would be concerned with enabling LVM mode unless it's absolutely necessary. @satoru-takeuchi Additional thoughts?

@satoru-takeuchi
Copy link
Member

@travisn I also hesitate to add this feature. LVM mode sometimes has pitfalls in container environment.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

Copy link

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants