Reproducible builds: Automatically remap $CARGO_HOME and $PWD

[kpcyrd]

As a followup of rust-lang/rust#41555, I think $CARGO_HOME and $PWD (the location of the project) should be remapped to fixed values automatically.

I found both of those paths inside binaries and I have to add boilerplate to all of my reprotest scripts to normalize them.

The motivation behind this is that alice and bob can both download the same release of a rust project, cargo build --release it and end up with a 100% identical binary, given a sufficiently similar build environment (rustc version and system libraries).

[alexcrichton]

Thanks for the report! I think this is plausible to do but currently if done naively I think it would break all debugger integrations, so we probably don't want to do this until that's fixed.

[sanxiyn]

Maybe we can do this only on release builds?

[alexcrichton]

If we can solve the debug problem, yes we may be able to do it by default on release builds as well.

[kpcyrd]

@alexcrichton debugging in rust depends on debug symbols, correct?

[profile.dev]
debug = true       # include debug information (debug symbols). Equivalent to
                   # `-C debuginfo=2` compiler flag.

couldn't we remap those paths if debug is set to false?

[alexcrichton]

Perhaps, but I believe they still show up in panic paths

[mfarrugi]

@alexcrichton Any additional colour on what could/would break wrt debuggers? I am somewhat surprised $PWD makes it into the binaries at all.

Edit:
When I run strings on a 1.29.2 release or debug binary, I don't see $PWD in there at all.

[alexcrichton]

@mfarrugi debuggers use the paths in debuginfo (which don't show up in strings output) for setting breakpoints and showing code whiel you're stepping through code. Anything which references a registry crate has an absolute path and can be debugged by setting breakpoints on the file and such. Crates in the cwd, if referenced via an absolute path, are also loaded by the debugger and would break as $PWD/foo.rs doesn't actually exist

[infinity0]

The question is what to map the paths to. In Debian we install source code into /usr/share/cargo/registry but other systems might be different. Ideally we'd map it to a virtual path like $CARGO_REGISTRY and put the logic of "where is $CARGO_REGISTRY" into the system debugger itself.

[chemsaf3]

these also look blocking

rust-lang/rust#40374
rust-lang/rust#40552
rust-lang/rust#75263

[sundeep-kokkonda]

I am also facing reproducible issue, reported in rust-lang/rust#102299

I tried adding--remap-path-prefix flag but still the binaries are not reproducible. But, I suspect my change is effective or not, can anyone let me know where exactly I should add this flag?

[sundeep-kokkonda]

@alexcrichton How can I make rust builds are reproducible? can you let me the procedure that you know or can u guide me?. The reproducible issue I faced is reported here rust-lang/rust#102299

[epage]

We also have rust-lang/rust#111540 which might help

[weihanglo]

Wonder if we should close this in favor of rust-lang/rust#111540 and #12137?

[ehuss]

Yea, closing since this is now implemented.