Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlashMap swept too early with nested filters. #41

Closed
rossabaker opened this issue Mar 21, 2011 · 1 comment
Closed

FlashMap swept too early with nested filters. #41

rossabaker opened this issue Mar 21, 2011 · 1 comment

Comments

@rossabaker
Copy link
Member

When two ScalatraFilters with FlashMapSupport are in the chain, the inner filter sweeps the flash map before the outer filter completes.

  • Sweep should only be called by the FlashMapSupport instance that created the flash map.
  • Automatic sweeping could be disabled. See paulitex's gist. This is the default behavior of Rack Flash. This puts the burden on the developer to access all attributes, but would play nicer with multiple redirects. Consider making this a configurable option like Rack Flash.
@rossabaker
Copy link
Member Author

Only the kernel that created the flash map sweeps it. [closed by 36b1fb5]

jboyens pushed a commit to jboyens/scalatra that referenced this issue Jul 1, 2011
@rossabaker
Only the kernel that created the flash map sweeps it. [closes scalatr…
36b1fb5 
…aGH-41]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rossabaker