Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: restore interfaces-account-control properly #3664

Merged
merged 1 commit into from
Aug 7, 2017

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Aug 7, 2017

When the test for interfaces-account-control runs twice it will
fail because the newly created "alice" user is not cleaned up.

Add the missing restore step for this.

When the test for interfaces-account-control runs twice it will
fail because the newly created "alice" user is not cleaned up.

Add the missing restore step for this.
@mvo5 mvo5 added this to the 2.27 milestone Aug 7, 2017
Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

restore: |
echo "Ensure alice is gone from the system"
for f in /var/lib/extrausers/*; do
sed -i '/^alice:/d' $f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know about the d modifier.

@codecov-io
Copy link

Codecov Report

Merging #3664 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3664      +/-   ##
==========================================
- Coverage   75.16%   75.15%   -0.01%     
==========================================
  Files         388      388              
  Lines       33655    33655              
==========================================
- Hits        25297    25294       -3     
- Misses       6539     6541       +2     
- Partials     1819     1820       +1
Impacted Files Coverage Δ
interfaces/sorting.go 98.71% <0%> (-1.29%) ⬇️
overlord/snapstate/snapstate.go 80.19% <0%> (-0.27%) ⬇️
overlord/ifacestate/helpers.go 62.33% <0%> (ø) ⬆️
cmd/snap/cmd_aliases.go 95% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653f17c...580c8f5. Read the comment docs.

@mvo5 mvo5 merged commit ab9c5d1 into canonical:master Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants