-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query-frontend: Set value of remote_user field in Slow Query Logs from HTTP header #7363
Merged
fpetkovski
merged 8 commits into
thanos-io:main
from
freenowtech:slow-query-logs-user-header
Jun 3, 2024
Merged
Query-frontend: Set value of remote_user field in Slow Query Logs from HTTP header #7363
fpetkovski
merged 8 commits into
thanos-io:main
from
freenowtech:slow-query-logs-user-header
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wndhydrnt
force-pushed
the
slow-query-logs-user-header
branch
from
May 15, 2024 13:11
430039c
to
21020e9
Compare
wndhydrnt
changed the title
Query-frontend: Set remote_user in Slow Query Logs from HTTP header
Query-frontend: Set value of remote_user field in Slow Query Logs from HTTP header
May 15, 2024
Signed-off-by: Markus Meyer <m.meyer@mytaxi.com>
Signed-off-by: Markus Meyer <m.meyer@mytaxi.com>
Signed-off-by: Markus Meyer <m.meyer@mytaxi.com>
Signed-off-by: Markus Meyer <m.meyer@mytaxi.com>
wndhydrnt
force-pushed
the
slow-query-logs-user-header
branch
from
May 17, 2024 12:08
934fef0
to
25ff6b6
Compare
fpetkovski
previously approved these changes
May 21, 2024
Signed-off-by: Markus Meyer <hydrantanderwand@gmail.com>
Signed-off-by: Markus Meyer <hydrantanderwand@gmail.com>
fpetkovski
approved these changes
Jun 3, 2024
Thanks for the review and the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7360.
Changes
query-frontend
command.remote_user
field from header if flag is set.Verification
thanos
binary locally.--query-frontend.slow-query-logs-user-header=<test header>
and--query-frontend.log-queries-longer-than=1s
./api/v1/query
that contains a long-running query and sets the<test header>
.