-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Stats Returned with query including query bytes fetched #7365
Comments
Please see https://github.com/thanos-io/promql-engine/pull/325/files and others for a previous attempt at this. We either want to have an improved Select() interface or pass these hints through |
Hi @GiedriusS thanks so much for the pointer, do you know why it is not merged into upstream? |
There are still some missing things: https://github.com/thanos-io/promql-engine/pull/325/files#diff-5b6024dfabe0bc120c9efaad778c55c7283d643c0ad2882eb7e47effa7aac384R24. Also, that PR needs some tests. There was also a suggestion to just pass Select() metadata through |
Yep, you could consider passing a function into ctx so no need to disrupt the query engine itself, reference about how M3 does that: https://github.com/databricks/m3/blob/db_main/src/query/api/v1/handler/prom/read.go#L270-L278 and |
published a PR here: #7390 |
Is your proposal related to a problem?
Currently prometheus stats do not work
Furthermore, we want to include query bytes fetched as a way to measure how expensive a query is when we query.
Describe the solution you'd like
Currently we found
However, we found the stats counter is only used as metric, and i have not found a way on how it is returned with query.
We plan to
Describe alternatives you've considered
still exploring down the path
Additional context
cc @moadz @bwplotka @douglascamata who previously worked on query performance metrics
(Write your answer here.)
The text was updated successfully, but these errors were encountered: