BZ-1195300: provide tooltips for ListBarWidget buttons.

AppFormer · Mar 11, 2015 · 17bf84b · 17bf84b
1 parent f656d83
commit 17bf84b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 1 deletion.
diff --git a/...workbench-client/src/main/java/org/uberfire/client/resources/i18n/WorkbenchConstants.java b/...workbench-client/src/main/java/org/uberfire/client/resources/i18n/WorkbenchConstants.java
@@ -32,6 +32,10 @@ public interface WorkbenchConstants
 
     String minimizePanel();
 
+    String closePanel();
+
+    String selectView();
+
     String expandToolbar();
 
     String collapseToolbar();

diff --git a/...nch-client/src/main/java/org/uberfire/client/workbench/widgets/listbar/ListBarWidget.java b/...nch-client/src/main/java/org/uberfire/client/workbench/widgets/listbar/ListBarWidget.java
@@ -31,6 +31,7 @@
 
 import org.jboss.errai.ioc.client.container.IOCResolutionException;
 import org.jboss.errai.security.shared.api.identity.User;
+import org.uberfire.client.resources.i18n.WorkbenchConstants;
 import org.uberfire.client.util.Layouts;
 import org.uberfire.client.workbench.PanelManager;
 import org.uberfire.client.workbench.panels.MultiPartWidget;
@@ -187,6 +188,7 @@ public void setup( boolean isMultiPart,
         this.menuArea.setVisible( false );
 
         if ( isMultiPart ) {
+            closeButton.setTitle( WorkbenchConstants.INSTANCE.closePanel() );
             closeButton.addClickHandler( new ClickHandler() {
                 @Override
                 public void onClick( ClickEvent event ) {

diff --git a/...h-client/src/main/java/org/uberfire/client/workbench/widgets/listbar/ListBarWidget.ui.xml b/...h-client/src/main/java/org/uberfire/client/workbench/widgets/listbar/ListBarWidget.ui.xml
@@ -22,6 +22,7 @@
              xmlns:ufp="urn:import:org.uberfire.client.workbench.widgets.panel">
 
   <ui:with field="res" type="org.uberfire.client.resources.WorkbenchResources"/>
+  <ui:with field="i18n" type="org.uberfire.client.resources.i18n.WorkbenchConstants"/>
 
   <ui:style>
     .title {
@@ -59,7 +60,9 @@
             <tb:Button ui:field="closeButton" size="MINI" icon="REMOVE"/>
           </tb:ButtonGroup>
           <tb:ButtonGroup ui:field="dropdownCaretContainer">
-            <tb:DropdownButton ui:field="dropdownCaret" size="MINI"/>
+            <tb:Tooltip trigger="HOVER" placement="BOTTOM" text="{i18n.selectView}">
+              <tb:DropdownButton ui:field="dropdownCaret" size="MINI"/>
+            </tb:Tooltip>
           </tb:ButtonGroup>
           <tb:ButtonGroup>
             <ufp:MaximizeToggleButton ui:field="maximizeButton"/>

diff --git a/...lient/src/main/resources/org/uberfire/client/resources/i18n/WorkbenchConstants.properties b/...lient/src/main/resources/org/uberfire/client/resources/i18n/WorkbenchConstants.properties
@@ -1,5 +1,7 @@
 maximizePanel=Maximize panel to fit full screen
 minimizePanel=Minimize panel to its previous size
+closePanel=Close this panel
+selectView=Select view
 expandToolbar=Expand Toolbar
 collapseToolbar=Collapse Toolbar