Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Firefox version of the addon to simply enable the built-in addon. #154

Open
wisniewskit opened this issue Apr 19, 2021 · 3 comments

Comments

@wisniewskit
Copy link
Member

Desktop and Android Firefox ship with a more feature-rich copy of the webcompat reporter, though it is disabled by default on release builds. As such we could simply have this add-on flip the pref to enable that version (extensions.webcompat-reporter.enabled).

It's unclear whether it will be considered kosher by the addons team to whitelist that specific pref for this specific addon, but I think a good enough case can be made to do so (less code to review in this add-on on AMO, less duplication in code, etc).

@gamer191
Copy link

Just wondering, how can one use extensions.webcompat-reporter.enabled? I tried enabling it and it did nothing. Does it require an extension to act as a GUI for it?

@wisniewskit
Copy link
Member Author

@gamer191, yes, to make it easier to ship updated versions out-of-sync with the main Firefox update process, and to access more helpful capabilities than normal web extensions can access, we ship a version of the webcompat reporter and webcompat interventions features as bundled ("system") addons on desktop and Android Firefox versions. That's why the prefs are named that way.

That said, that version of the addon should be bundled with desktop and Android Firefox, even if it's disabled by default except on pre-release versions. So if you're not seeing the Help menu as "Report Site Issue" appear after you toggle that preference, we would need to do some troubleshooting to figure out why that might be.

@gamer191
Copy link

gamer191 commented Nov 15, 2021

So if you're not seeing the Help menu as "Report Site Issue" appear after you toggle that preference, we would need to do some troubleshooting to figure out why that might be.

Thanks, I do see that. Apologies, I missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants