Existing canvas element, issue 157#192
Closed
daemonburrito wants to merge 1 commit into
Closed
Conversation
pre-existing canvas element. mrdoob#157
Owner
|
Patched! I haven't applied your code but I've done pretty much the same by hand with a few tweaks here and there. Thanks for the tip and sorry for the delay! |
Author
|
Yay! My first patch on github. Glad I could help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I'm new to github.
Seems a little silly to send a pull request for a one-liner, but here is the modification I made to use three.js for a little project of mine.
Please let me know if there was a cleaner way to do this regarding the build script (ie, do you pull contributor's builds), and anything else I did wrong...
Thanks for three.js.