Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCGV: Configurable background color for Out-ConsoleGridView #129

Open
r-darwish opened this issue Nov 22, 2020 · 10 comments
Open

OCGV: Configurable background color for Out-ConsoleGridView #129

r-darwish opened this issue Nov 22, 2020 · 10 comments
Labels

Comments

@r-darwish
Copy link

The default colors don't look well on every theme. It would be nice if we could configure them.

@r-darwish r-darwish changed the title Configurable background color Configurable background color for Out-ConsoleGridView Nov 22, 2020
@tig
Copy link
Collaborator

tig commented Jan 22, 2021

Can you share more details of what looks good and doesn't on your system?

Terminal.Gui, on which ocgv is based supports multiple color themes. One solution would be to add a switch to ocgv that lets the user choose these:

Base:
image

TopLevel:
image

Dialog:
image

Error:
image

Finding color schemes that work well cross-platform is a real challenge. We do have the ability to tweak the defaults across some platforms so if there's something in one of the defaults that looks awful on, say Linux, we have some control.

@Fred-Vatin
Copy link

Fred-Vatin commented Jun 6, 2021

Yes maybe a general theme setting for all terminal.gui applications or/and a specific command to set ocgv theme like set-ocgvColors and passing a hash table with colors like we do with Set-PSReadLineOption -Colors $myTheme.

I reckon some colors of ocgv don’t match. ocgv use darkcyan for title and the last focus line on blue bg. What a weird choice.
Here it is with the built-in campbell theme for wt.
image

Here was my personal theme for wt.
image
image

Adjusting my theme, I can get a better contrast.
image

However we definitely need a way to custom ocgv colors.

@jdhitsolutions
Copy link

I'll add my vote on this. In Windows Terminal, the only way you can adjust the display is to modify the color scheme definition for values like Blue and Cyan.

@tig
Copy link
Collaborator

tig commented Jun 3, 2022

Question for @r-darwish, @jdhitsolutions, and @freMea:

I think there are two issues here:

  1. The use of "blue on blue" for the list highlight is hard to see/has poor contrast.
  2. It would be nice to have the color scheme be user-configurable

Does this accurately reflect your take?

@Fred-Vatin
Copy link

Yes

@tig
Copy link
Collaborator

tig commented Jun 7, 2022

Ok. Thank you for the feedback!

For 1. see gui-cs/Terminal.Gui#1773

For 2. see gui-cs/Terminal.Gui#29

@tig
Copy link
Collaborator

tig commented Aug 4, 2022

gui-cs/Terminal.Gui#1773 has been fixed and will be in Terminal.Gui v1.7.2 which I plan on launching in the next day. It will be incorporated into the next GraphicalTools release.

image

It's not a dramatic change, but does make the not-focused but selected listview item easier to read.

Providing customizable colors is a future item...

@tig
Copy link
Collaborator

tig commented Aug 24, 2022

@andschwa please prefix title with "OCGV: ".

@andyleejordan andyleejordan changed the title Configurable background color for Out-ConsoleGridView OCGV: Configurable background color for Out-ConsoleGridView Aug 24, 2022
@tig
Copy link
Collaborator

tig commented Apr 28, 2023

Terminal.Gui v2.x will fix this.

See gui-cs/Terminal.Gui#2181

I plan on a re-write of OCGV using Terminal.Gui v2 in the next few months.

@SteveL-MSFT SteveL-MSFT added this to the Consider-1.0.0 milestone Jul 26, 2023
@HotCakeX
Copy link

Really need a way to customize background color...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants