Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto convert "ipfs://Qm..." into "ipfs://bafy or base32" #202

Open
SLT-World opened this issue Jul 22, 2022 · 2 comments
Open

Auto convert "ipfs://Qm..." into "ipfs://bafy or base32" #202

SLT-World opened this issue Jul 22, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed ipfs ipfs / ipns related

Comments

@SLT-World
Copy link

CID v0 doesn't work since Agregore Browser's engine, Chromium, as it turns out, converts URLs into lowercase. And IPFS does not work with lowercase CID v0.
It might be a useful feature to detect CID v0 and auto convert it into CID v1.
@RangerMauve
Copy link
Member

Do note that posting /ipfs/Qm... CIDs should resolve and convert automatically. It's just when you have ipfs://Qm URLs that it barfs.

@RangerMauve RangerMauve added enhancement New feature or request ipfs ipfs / ipns related help wanted Extra attention is needed labels Sep 5, 2022
@RangerMauve
Copy link
Member

If anyone wants to take a shot at it. it should be a pretty straightforard change inside omni-box.js to add a case for strings that start with ipfs://Qm and to convert the CID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed ipfs ipfs / ipns related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RangerMauve @SLT-World