Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak skip silence to make it less abrupt #4229

Open
rasferret opened this issue Jun 9, 2020 · 13 comments · May be fixed by #7185
Open

Tweak skip silence to make it less abrupt #4229

rasferret opened this issue Jun 9, 2020 · 13 comments · May be fixed by #7185

Comments

@rasferret
Copy link

App version: 2.0.0-RC4 (from Google Play) Commit: a7b38bd

Android version: 9 (Patchlevel May 1th 2019)

Device model: BQ Aquaris X2 Pro

The skip silence feature is very useful but most of the time it skips to much silence. It would be nice to have the amount, that is skipped, configurable. There is a issue at the exoplayer project that is related to this feature:

google/ExoPlayer#6705

@rasferret rasferret changed the title Make the skip silence configurable Make skip silence configurable Jun 9, 2020
@ByteHamster
Copy link
Member

Sorry, I think that a setting like this will confuse many new users. I am trying to reduce the number of settings to make AntennaPod easier to use instead of adding even more settings. You can find reasons for this in the following blog article: http://neugierig.org/software/blog/2018/07/options.html

@summersab
Copy link

I actually would like to see this feature, as well. Sometimes, the silence that is skipped becomes a bit "aggressive," and it disrupts the cadence and flow of the people talking on the podcasts. However, it would still nice to be able to skip sections when there are 500ms or more of silence.

Perhaps add it to an advanced settings section to cut down on potential confusion?

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/improvements-to-the-skip-silence-system/355/1

@tonytamsf
Copy link
Member

Once google/ExoPlayer#6705 is fixed (or ever fixed) we should tune the configurations we will use. I agree to not expose it as as option but we should make skip silence less abrupt

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/what-is-this-skip-silence-thing/406/1

@sopos
Copy link

sopos commented May 3, 2023

Once google/ExoPlayer#6705 is fixed (or ever fixed) we should tune the configurations we will use. I agree to not expose it as as option but we should make skip silence less abrupt

It appears to me teh ExoPlayer issue was fixed at the time you wrote the answer. I guess it could be implemented then, somehow.

The current aggressive silence skipping shrinks even breath pauses between words / sentences which make it much harder to understand. Some minimal pause should be maintained. The question is how long - 250ms?

Can we get this issue reopened?

@sopos
Copy link

sopos commented Jun 2, 2023

@ByteHamster, any possibility to change your mind?

@keunes
Copy link
Member

keunes commented Jun 2, 2023

@sopos ByteHamster is busy these months. As noted above, we don't want a setting. But I'll reopen it so we can see if we can tune it a bit:

we should tune the configurations we will use. I agree to not expose it as as option but we should make skip silence less abrupt

@keunes keunes changed the title Make skip silence configurable Tweak skip silence to make it less abrupt Jun 2, 2023
@keunes keunes reopened this Jun 2, 2023
@Friptick
Copy link

Hello. For the last few weeks I've been experiencing an annoying issue. Sometimes during playback, the first word of a sentence will disappear. At first I thought this was a recording issue, but I've had it on multiple podcasts so I assume Antennapod is responsible - and specifically this feature.

But I have not turned it on and I cannot even see a "Skip silence" setting!

Using v3.1.1 from F-Droid.

What could be going on?

@ByteHamster
Copy link
Member

Using the settings icon on the player page. In the future (or if you have any other questions about this), please ask support questions on forum.antennapod.org, not on the issue tracker.

@Friptick
Copy link

Thanks. But it is not a support request, it is an issue, for the reason I gave:

But I have not turned it on and I cannot even see a "Skip silence" setting!

The feature is activating itself unbidden on v3.1.1.

I don't want it and didn't enable it. I can double-confirm this now I have seen the setting with its empty checkbox.

Not complaining, but it is an issue, happening on multiple podcasts.

@Friptick
Copy link

Update.

I can double-confirm this now I have seen the setting with its empty checkbox.

On v3.1.2 the setting has disappeared again. Have not experienced the problem recently.

MartinNowak added a commit to MartinNowak/AntennaPod that referenced this issue Jan 29, 2024
MartinNowak added a commit to MartinNowak/AntennaPod that referenced this issue Jan 29, 2024
MartinNowak added a commit to MartinNowak/AntennaPod that referenced this issue Jan 29, 2024
MartinNowak added a commit to MartinNowak/AntennaPod that referenced this issue Jan 29, 2024
@ByteHamster
Copy link
Member

Details about what was decided regarding this feature: #6910 (comment)

MartinNowak added a commit to MartinNowak/AntennaPod that referenced this issue Mar 9, 2024
MartinNowak added a commit to MartinNowak/AntennaPod that referenced this issue Mar 21, 2024
- followup feed-specific skip silence config (AntennaPod#6910)
- toggle buttons to configure
- medium 300ms gap
- aggressive 50ms gap
MartinNowak added a commit to MartinNowak/AntennaPod that referenced this issue May 5, 2024
- followup feed-specific skip silence config (AntennaPod#6910)
- toggle buttons to configure
- medium 300ms gap
- aggressive 50ms gap
MartinNowak added a commit to MartinNowak/AntennaPod that referenced this issue May 17, 2024
- followup feed-specific skip silence config (AntennaPod#6910)
- toggle buttons to configure
- medium 300ms gap
- aggressive 50ms gap
MartinNowak added a commit to MartinNowak/AntennaPod that referenced this issue May 17, 2024
- followup feed-specific skip silence config (AntennaPod#6910)
- toggle buttons to configure
- medium 300ms gap
- aggressive 50ms gap
MartinNowak added a commit to MartinNowak/AntennaPod that referenced this issue May 17, 2024
- followup feed-specific skip silence config (AntennaPod#6910)
- toggle buttons to configure
- medium 300ms gap
- aggressive 50ms gap
@MartinNowak MartinNowak linked a pull request May 18, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants