Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with Gradle 2.13 #304

Open
ben-muldrow opened this issue Jun 14, 2016 · 4 comments
Open

Build failure with Gradle 2.13 #304

ben-muldrow opened this issue Jun 14, 2016 · 4 comments
Assignees

Comments

@ben-muldrow
Copy link
Collaborator

Java Version: 1.8.0_73
Gradle Version: 2.13
OS: OS X 10.11.5 (El Capitan)
Topsoil Version: v1.0.0-alpha.10-2-g2c343e6


The build recently started failing with Gradle 2.13 caused by an exception with a Javascript library defined in the core/build.gradle as com.eriwen.gradle.js.

The gradle build failure report is as follows:

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/benjaminmuldrow/Documents/CIRDLES/Topsoil/core/build.gradle' line: 8

* What went wrong:
A problem occurred evaluating project ':core'.
> Could not create an instance of type com.eriwen.gradle.js.source.internal.DefaultJavaScriptSourceSet_Decorated.

I will be monitoring this problem further and looking for a fix or work-around.

@ben-muldrow
Copy link
Collaborator Author

@buncesam @bowring

@buncesam
Copy link

I am getting the same issue with Gradle version 2.14

@ben-muldrow
Copy link
Collaborator Author

It looks like the eriwen/gradle-js-plugin version used in the core/build.gradle was incompatible with gradle versions 2.1 and above. by updating the version, the build and run tasks pass with no exception. I will make a relevant pull request updating the build file.

@johnzeringue
Copy link
Contributor

johnzeringue commented Jun 14, 2016

I'll let y'all figure this out on your own, but I thought I'd chime in.

Basically, you shouldn't use your local Gradle install to build Topsoil, you should use the wrapper instead (via gradlew, ./gradlew, ./gradlew.bat, etc.). This keeps everyone on the same Gradle version, preventing updates to Gradle from becoming distractions.

That's not to say that the build script failing with the latest Gradle isn't technical debt—it is. But you should think of this as less of a "bug" and more of an "enhancement" to tackle when you have the time to get the build script working with a newer version of Gradle and update the wrapper with gradle wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants