Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use random_seed argument #44

Open
cciccole opened this issue Jun 14, 2019 · 2 comments
Open

Actually use random_seed argument #44

cciccole opened this issue Jun 14, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cciccole
Copy link

The Python API has a random_seed attribute for the tsnecuda.TSNE class but it's ignored.

Random seed is tracked as an option within the tsnecuda implementation but it looks hard coded to time-based seed instead. Is there a good reason for this?

I might implement and PR this change unless you indicate otherwise or do it first.

@rmrao
Copy link
Collaborator

rmrao commented Jun 14, 2019

No good reason, we probably just got lazy.

If you submit a PR we will be happy to include it.

@DavidMChan
Copy link
Member

Just an FYI: the real reason that this argument is ignored is because I'm not entirely certain that we can enforce strict random seeding. There may be external sources of randomness that are introduced beyond random number generation in our code (for example, by the FAISS library, or by parallelism). Because of this, it's a bit more challenging to make sure that random seeding is actually possible, and I haven't done a full strict analysis of the code, so just note that seeding the random number generator may not actually create reproducible results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants