Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Missing translations #2620

Closed
2 tasks done
kubalav opened this issue Mar 26, 2024 · 7 comments · Fixed by #2727
Closed
2 tasks done

BUG: Missing translations #2620

kubalav opened this issue Mar 26, 2024 · 7 comments · Fixed by #2727
Labels
bug Something isn't working

Comments

@kubalav
Copy link
Contributor

kubalav commented Mar 26, 2024

Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

Problem Description

The key registerHotkeyFailed isn't used in translations. The error message is displayed in English even if there is a translation. I have tried several languages.

To Reproduce

No response

Screenshots

No response

Flow Launcher Version

1.17.2

Windows Build Number

10.0.22621.3296

Error Log

No response

@kubalav kubalav added the bug Something isn't working label Mar 26, 2024
@taooceros
Copy link
Member

It's used here?

string errorMsg = string.Format(InternationalizationManager.Instance.GetTranslation("registerHotkeyFailed"), hotkeyStr);

@taooceros
Copy link
Member

Could you share a screenshot about the message that is only displayed in english?

@kubalav
Copy link
Contributor Author

kubalav commented Mar 26, 2024

Could you share a screenshot about the message that is only displayed in english?

I can't reproduce this error message. I can provide text only:

Failed to register hotkey "{0}". The hotkey may be in use by another program. Change to a different hotkey, or exit another program.

@taooceros
Copy link
Member

taooceros commented Mar 29, 2024

Could you recall how to you get this error message? Maybe list about how to reproduce (if you still remember) so we can locate where does that come from? It is also possible that crowdin hasn't been synced?

@kubalav
Copy link
Contributor Author

kubalav commented Mar 29, 2024

I was able to reproduce the error. It is enough if some application has an associated shortcut key like Flow Launcher uses to open the query box. Then you need to launch the Flow Launcher and the error message will be displayed at startup.

@jjw24
Copy link
Member

jjw24 commented Mar 31, 2024

@taooceros I think this error msg box is the one where the flow activation hotkey is being used by another program prior to flow registering it for itself. To repro- change flow to alt space hotkey, close flow, open PT Run which should be using the default alt space hotkey, and finally open flow and should see that error message.

@VictoriousRaptor
Copy link
Contributor

Are the translations loaded before hotkey registering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants