Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2nd definition group initially not visible after lookup #154

Closed
artjomsR opened this issue May 13, 2024 · 2 comments
Closed

2nd definition group initially not visible after lookup #154

artjomsR opened this issue May 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@artjomsR
Copy link
Contributor

artjomsR commented May 13, 2024

Describe the bug
After doing a lookup, the 2nd group always shows up as empty. If you go to the next definition (either by clicking the Next arrow or scrolling with the mouse wheel), then definitions appear again (starting from 2nd definition)

To Reproduce
Steps to reproduce the behavior:

  1. Enable 2nd dictionary group in settings
  2. Look up a word
  3. Notice the 2nd group is empty. If you were to create a card now, the 2nd definition will be left blank!
  4. Go to next definition in 2nd group
  5. Notice that 2nd group has a definition now
  6. Go to previous group and notice 1st definition is now available and visible

Expected behavior
2nd definition should be visible immediately after lookup

Desktop.2024.05.05.-.21.02.26.04.DVR.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Vocabsieve version (if nightly, must be latest): 7073e356ec45323837ed996fbda6fb6f8d442147 seems to be the offending commit 7073e35
@artjomsR artjomsR added the bug Something isn't working label May 13, 2024
@1over137
Copy link
Contributor

Can't reproduce this. Does this require that the first definition fail? It seems to work fine for me in c6bc862

@artjomsR
Copy link
Contributor Author

This is a strange one - I've fixed it locally by removing and readding the first (offending?) dictionary in the Sources tab. Now it works as expected. Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants