Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to contribute #147

Open
HDT3213 opened this issue Apr 2, 2023 · 0 comments
Open

How to contribute #147

HDT3213 opened this issue Apr 2, 2023 · 0 comments

Comments

@HDT3213
Copy link
Owner

HDT3213 commented Apr 2, 2023

简体中文

Pull Request Guidelines

Godis follows the common Pull Request (PR) process:

  1. Fork the repository to your own Github account.
  2. Develop on the forked copy.
  3. Submit a Pull Request to Godis.

We hope that your PR meets the following requirements:

  1. Please ensure that your code has been formatted by gofmt and passed golint checks.
  2. Please ensure that your code passes unit tests. You only need to start redis server listening on port 6379 locally to complete the unit test, but the test code may modify the data in the Redis server.
  3. When adding new features, please provide corresponding unit tests.
  4. Please keep the Git timeline clean. A PR should only contain one or several commits. Please squash unneeded commits produced during development before submitting a PR. Ensure that the PR does not contain merge nodes.

We will not reject any minor improvements, so you can confidently submit these PRs:

  1. Add comments
  2. Correct spelling errors
  3. Add new test cases
  4. Split functions or modules that are too complex
  5. Add Redis commands that are not currently supported but you think are useful

Please do not submit the following types of PRs:

  1. Make meaningless changes, such as using switch instead of if-else.
  2. Introduce unnecessary third-party libraries.

What Can I Do?

  1. You can familiarize yourself with the code and process by adding test cases or new commands to Godis.
  2. good first issue means that this issue is very suitable for beginners to participate in.
  3. You can see our plan on the project board.
@HDT3213 HDT3213 pinned this issue Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant