Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Regular leds wrong Z placement. #471

Open
leoheck opened this issue Nov 14, 2018 · 4 comments
Open

Regular leds wrong Z placement. #471

leoheck opened this issue Nov 14, 2018 · 4 comments

Comments

@leoheck
Copy link

leoheck commented Nov 14, 2018

I am seeing this for a long time ago.

Footprint: LED_THT:LED_D5.0mm
3d model: ${KISYS3DMOD}/LED_THT.3dshapes/LED_D5.0mm.wrl

To place it sitting the board, I had to shift it like Z = -3.0000

image

@jkriege2
Copy link
Collaborator

Why is this a bug? Basically you can mount these with any offset from the PCB. Some LEDs even have small nothes on the pins that prevent them from moving all to the board, if the drill hole is not very large:
2018-11-14 19_29_27-clipboard

I think if you need a specific distance from the boards it#s better to make your own special footprint, as many people will require many different offsets ...
Remember: this is a very generic footprint and cannot (by definition) fit to all use cases (e.g. we also don't have all colors of LEDs).

Best,
JAN

PS: @evanshultz @Misca1234 @antoniovazquezblanco What do you think? Should we move the LEDs directory onto the PCB, or make a series of different offsets? Maybe we should at least specify the ofset (but then measured from where to where?)

@Misca1234
Copy link
Collaborator

At most we could move them to the board but I do not think we should create a different series of distances.

I would like to vote to not move them, just keep them as they are, but if you all want to move them, it should not be a big problem

@evanshultz
Copy link
Collaborator

I think Jan is correct that this is preference or expectation and not a bug. However, moving them to the PCB is the obvious location to me as well and if that is the place most users expect it's probably the best place to locate these 3D models there to best meet expectations and avoid questions.

I agree the official library should be satisfactory with just one offset.

@leoheck
Copy link
Author

leoheck commented Nov 15, 2018

Hm interesting, I believe that by default it should be siting on the board. The lowest it can go is on top of the board. Moving it up is an alternative user configuration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants