Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Quickstep launch animation doesn't apply in some areas #4379

Open
validcube opened this issue May 12, 2024 · 0 comments
Open

[BUG] Quickstep launch animation doesn't apply in some areas #4379

validcube opened this issue May 12, 2024 · 0 comments
Labels

Comments

@validcube
Copy link
Contributor

validcube commented May 12, 2024

Describe the bug

This affects all functions launching activity without using Launcher3's launch activity (with Quickstep) function. (I don't think I even wrote this sentence right, let's skip that)

For example in the popup menu, the wallpaper picker uses Quickstep animation launch but not the app properties option and settings entry option

At first glance, I suspect this is because we are using launcher.startActivity(intent); instead of launcher.startActivitySafely(v, intent, placeholderInfo(intent)) like the one in startWallpaperPicker

private static boolean startSystemSettings(View view) {
final Launcher launcher = Launcher.getLauncher(view.getContext());
final Intent intent = new Intent(Settings.ACTION_SETTINGS);
launcher.startActivity(intent);
return true;
}

private static boolean startWallpaperPicker(View v) {
Launcher launcher = Launcher.getLauncher(v.getContext());
if (!Utilities.isWallpaperAllowed(launcher)) {
String message = launcher.getStringCache() != null
? launcher.getStringCache().disabledByAdminMessage
: launcher.getString(R.string.msg_disabled_by_admin);
Toast.makeText(launcher, message, Toast.LENGTH_SHORT).show();
return false;
}
Intent intent = new Intent(Intent.ACTION_SET_WALLPAPER)
.addFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK)
.putExtra(EXTRA_WALLPAPER_OFFSET,
launcher.getWorkspace().getWallpaperOffsetForCenterPage())
.putExtra(EXTRA_WALLPAPER_LAUNCH_SOURCE, "app_launched_launcher");
if (!Utilities.showStyleWallpapers(launcher)) {
intent.putExtra(EXTRA_WALLPAPER_FLAVOR, "wallpaper_only");
} else {
intent.putExtra(EXTRA_WALLPAPER_FLAVOR, "focus_wallpaper");
}
return launcher.startActivitySafely(v, intent, placeholderInfo(intent)) != null;
}

(for that one I will try to do a PR for it)

Steps to reproduce

Requirements:

  • Quickstep/Lawnstep-enabled Lawnchair 14
  • (optional) Preference
    • Enable: Show Settings Entry

Steps to reproduce the behaviour:

  1. Long press anywhere on the screen or any application until the popup menu appears
  2. Press on System Settings or App Info
  3. Observe the animation being launched compared to launching the wallpaper picker or application.

This behaviour can also be observed when using Lawnchair Device Search.

Expected behaviour

Lawnchair should launch all (or most) applications and intent with Quickstep animation.

Screenshots

Screen_Recording_20240512_192934_Settings.mp4

Device information

  • Device: Samsung M23 5G
  • OS: One UI 6 (Android 14) - March 2024
  • App version: Lawnchair 14 Beta 2

Additional context

No response

@validcube validcube added the bug label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant