Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mandatory Definition for words #3375

Open
nprime496 opened this issue May 17, 2024 · 1 comment
Open

Remove Mandatory Definition for words #3375

nprime496 opened this issue May 17, 2024 · 1 comment

Comments

@nprime496
Copy link

nprime496 commented May 17, 2024

I am trying to install the repo locally but I stumble upon this error:

RuntimeError: Error while exporting skill "Chiffres 2" in file "4_Numbers/skills/4_Numbers_2.yaml": The French word "téléphones" does not have a definition. Please add it to the mini-dictionary.

Reading the code, I notice that there's a check to ensure that all words have a correspondance in mini-dictionnary:

https://github.com/LibreLingo/LibreLingo/blob/3bb6d4deadc27cf7b762fcf63d7bb07ea0ccaac8/src/librelingo_json_export/dictionary.py#L52C1-L56C1

I do not think that it is necessary as it put too much constraints on course creation. Dictionnary should be added to improve existing courses not be an unavoidable requirement.

@Skivling
Copy link

I think the rationale behind this is so that people can hover over a word and it will show a definition. Although I agree with you that it shouldn't be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants