Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline annotations doesn't work #1073

Open
laurent-alfonsi-linaro opened this issue Aug 29, 2022 · 3 comments
Open

Multiline annotations doesn't work #1073

laurent-alfonsi-linaro opened this issue Aug 29, 2022 · 3 comments

Comments

@laurent-alfonsi-linaro
Copy link

laurent-alfonsi-linaro commented Aug 29, 2022

Hi I have tried to add a multi-line annotation, but it doesn't work.

$ curl --header 'Authorization: Token ' --data 'description=

the following benchmarks grew in size by more than 1%:
- 445.gobmk grew in size by 40% from 1406470 to 1963955 bytes
- 471.omnetpp grew in size by 15% from 554691 to 635347 bytes
- 483.xalancbmk grew in size by 12% from 3538944 to 3978300 bytes
- 400.perlbench grew in size by 12% from 938695 to 1048052 bytes

 &build=/api/builds/117225/'   https://qa-reports.linaro.org/api/annotations/
 {"url":"https://qa-reports.linaro.org/api/annotations/14/","id":14,"description":" the following benchmarks grew in size by more than 1%:\n - 445.gobmk grew in size by 40% from 1406470 to 1963955 bytes\n - 471.omnetpp grew in size by 15% from 554691 to 635347 bytes\n - 483.xalancbmk grew in size by 12% from 3538944 to 3978300 bytes\n - 400.perlbench grew in size by 12% from 938695 to 1048052 bytes","build":"https://qa-reports.linaro.org/api/builds/117225/"}

as you can see the \n are well stored in the database.

but the page displayed on qa-reports server shows all in one line :

Annotation: the following benchmarks grew in size by more than 1%: - 445.gobmk grew in size by 40% from 1406470 to 1963955 bytes - 471.omnetpp grew in size by 15% from 554691 to 635347 bytes - 483.xalancbmk grew in size by 12% from 3538944 to 3978300 bytes - 400.perlbench grew in size by 12% from 938695 to 1048052 bytes*

which is not very readable.

Can you confirm that this is a bug ? Is it be possible to add this to
your todo list ?

PS : I have also tried with html
. It doesn't work better. please advice.

@laurent-alfonsi-linaro
Copy link
Author

Another option is to accept a file ;-)
$ curl --header 'Authorization: Token ' --data 'description=@annotation_file&build=/api/builds/117225/' https://qa-reports.linaro.org/api/annotations/

Thanks

@chaws
Copy link
Collaborator

chaws commented Sep 20, 2022

@laurent-alfonsi-linaro

Could you please try using some<br />annotation? I tried it locally and it worked.

@laurent-alfonsi-linaro
Copy link
Author

I couldn't use it.
I tried "
" and "
" and the classic "
". none of them worked. see :
https://qa-reports.linaro.org/tcwg/tcwg_bmk_ci_gnu-build-tcwg_bmk_tk1-gnu-release-arm-spec2k6-O3_LTO/build/291/metadata/

btw, I m pushing using
$ curl --header xxx --form tests=@results-functional.json --form metrics=@results-metrics.json --form metadata=@results-metadata.json https://qa-reports.linaro.org//api/submit/tcwg/tcwg_bmk_ci_gnu-build-tcwg_bmk_tk1-gnu-release-arm-spec2k6-O3_LTO/291/400.perlbench

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants