Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request show IPv4 and IPv6 under Server Info #10

Closed
Pierre-Gronau-ndaal opened this issue Jul 23, 2023 · 1 comment · May be fixed by #99
Closed

feature request show IPv4 and IPv6 under Server Info #10

Pierre-Gronau-ndaal opened this issue Jul 23, 2023 · 1 comment · May be fixed by #99

Comments

@Pierre-Gronau-ndaal
Copy link

No description provided.

@Lissy93
Copy link
Owner

Lissy93 commented Aug 26, 2023

Closing as no desc

@Lissy93 Lissy93 closed this as completed Aug 26, 2023
pauljmartinez added a commit to pauljmartinez/fork-lissy93--web-check that referenced this issue Mar 1, 2024
This PR attempts to resolve Lissy93#10; however, I only just started using Web-Check and this may not be the preferred approach. That said, I’m happy to incorporate any feedback to make this PR more useful. :)

One unresolved issue is related to `api/threats.js` which appears to indicate that GOOGLE_CLOUD_API_KEY may be intended to work for both Page Speed Insights (Lighthouse) and Google Safe Browsing. Any clarification here would be greatly appreciated.

The gist of this update is to rename the API key environment variable and to provide a more direct URL to assist users with adding support for the Quality Summary section of the report.

Additionally, this may introduce a breaking change for current users as they would need to modify their environment variables. I’m not sure how to best handle this type of situation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants