Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNPACK with Windows support #190

Open
ghost opened this issue Jun 4, 2020 · 4 comments
Open

NNPACK with Windows support #190

ghost opened this issue Jun 4, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Jun 4, 2020

Hi,

I've made a Windows port (re-)available (the old and currently unavailable zeno40/nnpack-windows repo) with a lot of improvements in CMake support and other kinds of cleanups. It still haves to bypass the FFT16x16 kernel in AVX2 with it psimd counterpart to get everything working:

https://github.com/zulma46/NNPACK

Thanks

@erip
Copy link

erip commented Aug 31, 2020

Is this something that would be possible to contribute back, @zulma46? Assuming @Maratyszcza is willing to accept the PR, this would be immensely helpful to address some Windows feature parity issues for PyTorch (and presumably other tools relying on NNPACK).

@Maratyszcza
Copy link
Owner

There are no plans to merge Windows support. My work is now focused on the XNNPACK project. XNNPACK supports Windows, and is integrated into PyTorch as well.

@erip
Copy link

erip commented Aug 31, 2020

@Maratyszcza unfortunately nnpack isn't optional for java bindings, which is the only remaining non-Windows compatible dependency

@larryliu0820
Copy link

In case people are still looking for windows support, I just submit a PR #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants