Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QR code to account link dialog #5370

Open
1 task done
papaia opened this issue Mar 21, 2024 · 0 comments
Open
1 task done

Add QR code to account link dialog #5370

papaia opened this issue Mar 21, 2024 · 0 comments
Labels
Auth MSA and Mojang auth related issues suggestion Feature suggestions that have not been accepted yet.

Comments

@papaia
Copy link

papaia commented Mar 21, 2024

Role

I switch between (and log in to) multiple different accounts on different computers.

Suggestion

When adding a Microsoft account, the dialog asks you to browse to /link and enter a code. A QR code that points to the link would make it easier to use. Also, the OTC can be embedded in the URL for easier access with the otc parameter: https://www.microsoft.com/link?otc=CODE_HERE.

Benefit

This would make it easier and more smooth when logging in to the account on a mobile phone.

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

The addition would affect the MSALoginDialog UI, specifically the MSALoginDialog::showVerificationUriAndCode method, which would create the QR code and display it after along with the text.

void MSALoginDialog::showVerificationUriAndCode(const QUrl& uri, const QString& code, int expiresIn) {

@phit phit added suggestion Feature suggestions that have not been accepted yet. Auth MSA and Mojang auth related issues labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auth MSA and Mojang auth related issues suggestion Feature suggestions that have not been accepted yet.
Projects
None yet
Development

No branches or pull requests

2 participants