Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generateFunctionCall and generateFunctionCallMultipleOutputsDTO generate code without fromAddress #2

Open
StefH opened this issue Dec 29, 2017 · 5 comments

Comments

@StefH
Copy link

StefH commented Dec 29, 2017

The following C# code is generated:

public Task<bool> StoreDocumentAsyncCall(byte[] key, string name, string description) {
  var function = GetFunctionStoreDocument();
  return function.CallAsync<bool>(key, name, description);
}

And it would be better if also this code was generated:

public Task<bool> StoreDocumentAsyncCall(string addressFrom, byte[] key, string name, string description, HexBigInteger gas = null, HexBigInteger valueAmount = null) {
  var function = GetFunctionStoreDocument();
  return function.CallAsync<bool>(addressFrom, gas, valueAmount, key, name, description);
}
@StefH
Copy link
Author

StefH commented Jan 4, 2018

@juanfranblanco
Copy link
Member

Thanks, I'll have a look over the weekend

@juanfranblanco
Copy link
Member

Nice stuff, I have started to move code to common templates, you might find that useful. Also, note I am going to start generating more CQS based stuff.

@StefH
Copy link
Author

StefH commented Jan 8, 2018

Cool, if you have an update I would like to see that.

@juanfranblanco
Copy link
Member

Yes I will push something this week, nothing major just starting, I am consolidating ideas to generate UI viewmodels, cqs, etc.. But having common utilities is a must to reduce the copy and paste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants